Add MarkerView plugin #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-markerview-plugin
branch
from
20b35b4
to
40a3008
Compare
LukasPaczos
reviewed
Sep 6, 2018
| this.mapboxMap = mapboxMap; | ||
| } | ||
|
|
||
| public void onDestroy() { |
There was a problem hiding this comment.
This call is missing in the example. This method should probably be limited to the main thread as well.
|
|
||
| @UiThread | ||
| public void addMarker(@NonNull MarkerView markerView) { | ||
| if (markers.contains(markerView)) { |
There was a problem hiding this comment.
We should check here for MapView#isDestroyed, not to hook the listener into a destroyed map.
tobrun
force-pushed
the
tvn-markerview-plugin
branch
from
40a3008
to
f137c8c
Compare
tobrun
force-pushed
the
tvn-markerview-plugin
branch
from
f137c8c
to
98d3e7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream in the Mapbox Maps SDK for Android, we have deprecated MarkerView for almost a year. While this API can unblock certain use-cases, it isn't ideal and has no place in the main SDK. We plan to remove support of this API in the next major version (v7.0.0). To not block users still using this deprecated API, we are moving this feature inside a plugin instead.